Skip to content

[mdspan.layout.left.obs] Add missing noexcept #7831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

[mdspan.layout.left.obs] Add missing noexcept #7831

merged 1 commit into from
Apr 14, 2025

Conversation

hewillk
Copy link
Contributor

@hewillk hewillk commented Apr 13, 2025

Function declarations have noexcept, so this should be a typo.

jwakely
jwakely approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having noexcept here violates the Lakos rule but is consistent with the other layout mappings, and with the synopsis (as noted).

@jensmaurer jensmaurer merged commit 317ae89 into cplusplus:main Apr 14, 2025
2 checks passed
@hewillk hewillk deleted the main-void branch April 14, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hewillk @jwakely @jensmaurer